Added a check for documentation/decision content being specified.

structurizr · Aug 15, 2018 · 3b156b9 · 3b156b9
1 parent 87a86f5
commit 3b156b9
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/Structurizr.Core.Tests/Documentation/DocumentationTests.cs b/Structurizr.Core.Tests/Documentation/DocumentationTests.cs
@@ -45,6 +45,20 @@ public void test_addSection_ThrowsAnException_WhenTheTitleIsNotSpecified()
             }
         }
 
+        [Fact]
+        public void test_addSection_ThrowsAnException_WhenTheContentIsNotSpecified()
+        {
+            try
+            {
+                _documentation.AddSection(null, "Title", Format.Markdown, null);
+                throw new TestFailedException();
+            }
+            catch (ArgumentException iae)
+            {
+                Assert.Equal("Content must be specified.", iae.Message);
+            }
+        }
+
         [Fact]
         public void test_addSection_ThrowsAnException_WhenASectionExistsWithTheSameTitle()
         {
@@ -132,6 +146,20 @@ public void test_addDecision_ThrowsAnException_WhenTheTitleIsNotSpecified()
             }
         }
 
+        [Fact]
+        public void test_addDecision_ThrowsAnException_WhenTheContentIsNotSpecified()
+        {
+            try
+            {
+                _documentation.AddDecision("1", new DateTime(), "Title", DecisionStatus.Accepted, Format.Markdown, null);
+                throw new TestFailedException();
+            }
+            catch (ArgumentException iae)
+            {
+                Assert.Equal("Content must be specified.", iae.Message);
+            }
+        }
+
         [Fact]
         public void test_addDecision_ThrowsAnException_WhenADecisionExistsWithTheSameId()
         {

diff --git a/Structurizr.Core/Documentation/Documentation.cs b/Structurizr.Core/Documentation/Documentation.cs
@@ -72,6 +72,7 @@ internal Section AddSection(Element element, string title, Format format, string
             }
 
             CheckTitleIsSpecified(title);
+            CheckContentIsSpecified(content);
             CheckSectionIsUnique(element, title);
             CheckFormatIsSpecified(format);
 
@@ -88,6 +89,14 @@ private void CheckTitleIsSpecified(string title)
             }
         }
 
+        private void CheckContentIsSpecified(string title)
+        {
+            if (String.IsNullOrWhiteSpace(title))
+            {
+                throw new ArgumentException("Content must be specified.");
+            }
+        }
+
         private void CheckFormatIsSpecified(Format format)
         {
             if (format == null)
@@ -129,6 +138,7 @@ public Decision AddDecision(SoftwareSystem softwareSystem, string id, DateTime d
         {
             CheckIdIsSpecified(id);
             CheckTitleIsSpecified(title);
+            CheckContentIsSpecified(content);
             CheckDecisionStatusIsSpecified(status);
             CheckFormatIsSpecified(format);
             CheckDecisionIsUnique(softwareSystem, id);