This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Add C4-PlantUML Properties to Deployment_Nodes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way Deployment Nodes were rendered, the code path to add C4-PlantUML AddProperty Attributes was not being called. This change adds a check to if the `c4plantuml.elementProperties` property has been set in the `startDeploymentNodeBoundary` method to ensure any model properties assigned to Deployment Nodes will also be rendered on exported C4-PlantUML diagrams. This is an addition to the old behaviour where the properties were only rendered on container views.
djjlewis
force-pushed
the
c4plantuml-deployment-node-properties
branch
from
96fae3c
to
cd439ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way Deployment Nodes were rendered, the code path to add C4-PlantUML AddProperty Attributes was not being called.
This change adds a check to see if the
c4plantuml.elementPropertiesproperty has been set in thestartDeploymentNodeBoundarymethod to ensure any model properties assigned to Deployment Nodes will also be rendered on exported C4-PlantUML diagrams.This is an addition to the old behaviour where the properties were only rendered on container views.