Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to EREs #24

Closed
strugee opened this issue Oct 14, 2018 · 2 comments
Closed

Port to EREs #24

strugee opened this issue Oct 14, 2018 · 2 comments

Comments

@strugee
Copy link
Owner

strugee commented Oct 14, 2018

We can't use | in BREs portably, which is a no-go. See https://stackoverflow.com/questions/22877457/can-a-b-expression-be-used-in-grep-bre-mode#comment34926946_22877494.

The solution is to port to EREs which will let us use | portably.
@strugee
Copy link
Owner Author

strugee commented Oct 14, 2018

Plus, the escaping is a nightmare anyway.

@strugee
Copy link
Owner Author

strugee commented Oct 14, 2018

Blocks #14, #12

strugee added a commit that referenced this issue Oct 14, 2018
@strugee
Convert to using EREs
992eb15 
Closes #24. Note that this is required for POSIX compatibility since
\| in BREs is apparently a GNU extension. See
https://stackoverflow.com/a/22877494/1198896#comment34926946_22877494,
along with POSIX.1-2017 (IEEE Std 1003.1-2017), Section 9.3:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
strugee added a commit that referenced this issue Oct 15, 2018
@strugee
Convert to using EREs
250921a 
Closes #24. Note that this is required for POSIX compatibility since
\| in BREs is apparently a GNU extension. See
https://stackoverflow.com/a/22877494/1198896#comment34926946_22877494,
along with POSIX.1-2017 (IEEE Std 1003.1-2017), Section 9.3:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
strugee added a commit that referenced this issue Oct 15, 2018
@strugee
Convert to using EREs
f7b9298 
Closes #24. Note that this is required for POSIX compatibility since
\| in BREs is apparently a GNU extension. See
https://stackoverflow.com/a/22877494/1198896#comment34926946_22877494,
along with POSIX.1-2017 (IEEE Std 1003.1-2017), Section 9.3:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html

Plus, I'm pretty sure we'll get a performance boost since EREs don't
have capturing groups.
@strugee strugee closed this as completed in f3f2690 Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@strugee