Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack-buffer-overflow in fallback-motion.cc: void put_qpel_fallback<unsigned short> #343

Closed
fdu-sec opened this issue Oct 10, 2022 · 2 comments
Closed

Stack-buffer-overflow in fallback-motion.cc: void put_qpel_fallback<unsigned short> #343

fdu-sec opened this issue Oct 10, 2022 · 2 comments
Labels
fix available

Comments

@fdu-sec
Copy link

fdu-sec commented Oct 10, 2022

Description

Stack-buffer-overflow (/libde265/build/libde265/liblibde265.so+0x14bef2) in void put_qpel_fallback(short*, long, unsigned short const*, long, int, int, short*, int, int, int)

Version

$ ./dec265 -h
 dec265  v1.0.8
--------------
usage: dec265 [options] videofile.bin
The video file must be a raw bitstream, or a stream with NAL units (option -n).

options:
  -q, --quiet       do not show decoded image
  -t, --threads N   set number of worker threads (0 - no threading)
  -c, --check-hash  perform hash check
  -n, --nal         input is a stream with 4-byte length prefixed NAL units
  -f, --frames N    set number of frames to process
  -o, --output      write YUV reconstruction
  -d, --dump        dump headers
  -0, --noaccel     do not use any accelerated code (SSE)
  -v, --verbose     increase verbosity level (up to 3 times)
  -L, --no-logging  disable logging
  -B, --write-bytestream FILENAME  write raw bytestream (from NAL input)
  -m, --measure YUV compute PSNRs relative to reference YUV
  -T, --highest-TID select highest temporal sublayer to decode
      --disable-deblocking   disable deblocking filter
      --disable-sao          disable sample-adaptive offset filter
  -h, --help        show help

Replay

git clone https://github.com/strukturag/libde265.git
cd libde265
mkdir build
cd build
cmake ../ -DCMAKE_CXX_FLAGS="-fsanitize=address"
make -j$(nproc)
./dec265/dec265 poc9-1
./dec265/dec265 poc9-2
./dec265/dec265 poc9-3
./dec265/dec265 poc9-4

ASAN

WARNING: pps header invalid
WARNING: CTB outside of image area (concealing stream error...)
WARNING: maximum number of reference pictures exceeded
WARNING: faulty reference picture list
WARNING: non-existing PPS referenced
WARNING: faulty reference picture list
=================================================================
==18325==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffd5f83a761 at pc 0x7f031a7b3ef3 bp 0x7ffd5f838110 sp 0x7ffd5f838100
READ of size 2 at 0x7ffd5f83a761 thread T0
    #0 0x7f031a7b3ef2 in void put_qpel_fallback<unsigned short>(short*, long, unsigned short const*, long, int, int, short*, int, int, int) (/libde265/build/libde265/liblibde265.so+0x14bef2)
    #1 0x7f031a7af248 in put_qpel_2_1_fallback_16(short*, long, unsigned short const*, long, int, int, short*, int) (/libde265/build/libde265/liblibde265.so+0x147248)
    #2 0x7f031a7df40d in acceleration_functions::put_hevc_qpel(short*, long, void const*, long, int, int, short*, int, int, int) const (/libde265/build/libde265/liblibde265.so+0x17740d)
    #3 0x7f031a7e08ab in void mc_luma<unsigned char>(base_context const*, seq_parameter_set const*, int, int, int, int, short*, int, unsigned char const*, int, int, int, int) (/libde265/build/libde265/liblibde265.so+0x1788ab)
    #4 0x7f031a7d1995 in generate_inter_prediction_samples(base_context*, slice_segment_header const*, de265_image*, int, int, int, int, int, int, int, PBMotion const*) (/libde265/build/libde265/liblibde265.so+0x169995)
    #5 0x7f031a7de90f in decode_prediction_unit(base_context*, slice_segment_header const*, de265_image*, PBMotionCoding const&, int, int, int, int, int, int, int, int) (/libde265/build/libde265/liblibde265.so+0x17690f)
    #6 0x7f031a8197e3 in read_prediction_unit(thread_context*, int, int, int, int, int, int, int, int, int) (/libde265/build/libde265/liblibde265.so+0x1b17e3)
    #7 0x7f031a81b264 in read_coding_unit(thread_context*, int, int, int, int) (/libde265/build/libde265/liblibde265.so+0x1b3264)
    #8 0x7f031a81c250 in read_coding_quadtree(thread_context*, int, int, int, int) (/libde265/build/libde265/liblibde265.so+0x1b4250)
    #9 0x7f031a813726 in read_coding_tree_unit(thread_context*) (/libde265/build/libde265/liblibde265.so+0x1ab726)
    #10 0x7f031a81c9ea in decode_substream(thread_context*, bool, bool) (/libde265/build/libde265/liblibde265.so+0x1b49ea)
    #11 0x7f031a81e70f in read_slice_segment_data(thread_context*) (/libde265/build/libde265/liblibde265.so+0x1b670f)
    #12 0x7f031a77d6d2 in decoder_context::decode_slice_unit_sequential(image_unit*, slice_unit*) (/libde265/build/libde265/liblibde265.so+0x1156d2)
    #13 0x7f031a77dec1 in decoder_context::decode_slice_unit_parallel(image_unit*, slice_unit*) (/libde265/build/libde265/liblibde265.so+0x115ec1)
    #14 0x7f031a77cc0f in decoder_context::decode_some(bool*) (/libde265/build/libde265/liblibde265.so+0x114c0f)
    #15 0x7f031a77c93d in decoder_context::read_slice_NAL(bitreader&, NAL_unit*, nal_header&) (/libde265/build/libde265/liblibde265.so+0x11493d)
    #16 0x7f031a77f43e in decoder_context::decode_NAL(NAL_unit*) (/libde265/build/libde265/liblibde265.so+0x11743e)
    #17 0x7f031a77fab3 in decoder_context::decode(int*) (/libde265/build/libde265/liblibde265.so+0x117ab3)
    #18 0x7f031a766e95 in de265_decode (/libde265/build/libde265/liblibde265.so+0xfee95)
    #19 0x5564657f6bc9 in main (/libde265/build/dec265/dec265+0x6bc9)
    #20 0x7f031a298c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    #21 0x5564657f49b9 in _start (/libde265/build/dec265/dec265+0x49b9)

Address 0x7ffd5f83a761 is located in stack of thread T0 at offset 9121 in frame
    #0 0x7f031a7dffb7 in void mc_luma<unsigned char>(base_context const*, seq_parameter_set const*, int, int, int, int, short*, int, unsigned char const*, int, int, int, int) (/libde265/build/libde265/liblibde265.so+0x177fb7)

  This frame has 2 object(s):
    [32, 9120) 'mcbuffer' <== Memory access at offset 9121 overflows this variable
    [9152, 14832) 'padbuf'
HINT: this may be a false positive if your program uses some custom stack unwind mechanism or swapcontext
      (longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-buffer-overflow (/libde265/build/libde265/liblibde265.so+0x14bef2) in void put_qpel_fallback<unsigned short>(short*, long, unsigned short const*, long, int, int, short*, int, int, int)
Shadow bytes around the buggy address:
  0x10002beff490: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10002beff4a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10002beff4b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10002beff4c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10002beff4d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x10002beff4e0: 00 00 00 00 00 00 00 00 00 00 00 00[f2]f2 f2 f2
  0x10002beff4f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10002beff500: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10002beff510: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10002beff520: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x10002beff530: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==18325==ABORTING

POC

https://github.com/FDU-Sec/poc/blob/main/libde265/poc9-1
https://github.com/FDU-Sec/poc/blob/main/libde265/poc9-2
https://github.com/FDU-Sec/poc/blob/main/libde265/poc9-3
https://github.com/FDU-Sec/poc/blob/main/libde265/poc9-4

Environment

Ubuntu 16.04
Clang 10.0.1
gcc 5.5

Credit

Peng Deng (Fudan University)
@coldtobi
Copy link

According to Debian this is CVE-2022-43236

coldtobi pushed a commit to coldtobi/libde265 that referenced this issue Dec 12, 2022
Use the sps from the image
36391cd 
(as e.g mc_chroma is using the sps to determine
picture properties, like pic_width_in_luma_samples
and pic_height_in_luma_samples, I *think* this is
more correct.

This PR is for discussion. (See strukturag#345.)
It makes the failures go away, but that does not mean it's correct :)

The following poc will be stop failing if (only) this
patch is applied:

 - poc2  strukturag#336 - CVE-2022-43238
 - poc4  strukturag#338 - CVE-2022-43241
 - poc6-1, poc6-2 strukturag#340 - CVE-2022-43242
 - poc7-1, poc7-2  strukturag#341 - CVE-2022-43239
 - poc8-1 strukturag#342 - CVE-2022-43244
 - poc9-3 strukturag#343 - CVE-2022-43236
 - poc10-2, poc10-3 strukturag#344 - CVE-2022-43237
 - poc16 strukturag#350
 - poc19 strukturag#353

The following are still failing if only this patch is
applied, but they stop failing if strukturag#365 is applied as well, but will
still fail with ONLY strukturag#365 applied (IOW, both are needed)

 - poc1  strukturag#335 - CVE-2022-43240
 - poc3  strukturag#337 - CVE-2022-43235
 - poc5   strukturag#339 - CVE-2022-43423
 - poc9-1,poc9-2, poc9-4  strukturag#343 - CVE-2022-43236
 - poc14  strukturag#348 - CVE-2022-43253
 - poc15  strukturag#349 - CVE-2022-43248
 - poc17-1, poc17-2  strukturag#351
 - poc18 strukturag#352 - CVE-2022-43245
@coldtobi coldtobi mentioned this issue Dec 12, 2022
Open
farindk added a commit that referenced this issue Jan 24, 2023
@farindk
MC: check that image bit-depth matches SPS bit depth (#343)
280c374
@farindk
Copy link
Contributor

farindk commented Jan 24, 2023

Should be fixed by #376

@farindk farindk closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@farindk @coldtobi @fdu-sec