Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client message processing asynchronous. #111

Merged
merged 6 commits into from
Jun 4, 2021

Conversation

fancycode
Copy link
Member

This helps in detecting clients that disconnect while a backend request for them is still active (e.g. joining a room).

@coveralls
Copy link

coveralls commented May 31, 2021

Pull Request Test Coverage Report for Build 906456468

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 59 of 100 (59.0%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 46.61%

Changes Missing Coverage Covered Lines Changed/Added Lines %
room.go 1 2 50.0%
client.go 24 26 92.31%
virtualsession.go 3 9 33.33%
clientsession.go 1 9 11.11%
hub.go 27 51 52.94%
Files with Coverage Reduction New Missed Lines %
client.go 2 71.14%
Totals Coverage Status
Change from base Build 906438228: 0.2%
Covered Lines: 3506
Relevant Lines: 7522

💛 - Coveralls

@fancycode fancycode force-pushed the async-client-processing branch 2 times, most recently from 667fcc4 to 180ef18 Compare June 1, 2021 07:52
This helps in detecting clients that disconnect while a backend request for
them is still active (e.g. joining a room).
If a client resumed a session while a (slow) backend request to join a room
was still active, the response could get lost.
@fancycode fancycode merged commit 9a921a6 into master Jun 4, 2021
@fancycode fancycode deleted the async-client-processing branch June 4, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants