Various test improvements #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancycode
force-pushed
the
test-improvements
branch
from
80168fc
to
2352143
Compare
fancycode
force-pushed
the
test-improvements
branch
3 times, most recently
from
c118224
to
9e0965f
Compare
Pull Request Test Coverage Report for Build 917465153Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
fancycode
force-pushed
the
test-improvements
branch
2 times, most recently
from
b2e7470
to
eb16d45
Compare
Only use one goroutine per client instead of one per subscription. This ensures that (like with the "real" client), all messages are processed in order across different subscriptions.
fancycode
force-pushed
the
test-improvements
branch
from
9f6d44f
to
b056fe9
Compare
fancycode
force-pushed
the
test-improvements
branch
from
b056fe9
to
2628735
Compare
Can happen mostly during tests (e.g. TestClientTakeoverRoomSession) where the new client could receive the "leave" event that was sent before it joined the room (but got delivered after joining).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.