Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.0.0 release #654

Closed
26 tasks done
simondel opened this issue Mar 15, 2018 · 13 comments
Closed
26 tasks done

Prepare 1.0.0 release #654

simondel opened this issue Mar 15, 2018 · 13 comments

Comments

@simondel
Copy link
Member

simondel commented Mar 15, 2018

With the 1.0.0 release with Stryker we will make the following changes:

Preparation

Execution

  • Remove deprecated Factories from stryker-api.
  • Remove ES5 mutator
  • Set 'javascript' as the default mutator
  • Remove deprecated reporter config key
  • Remove deprecated project config key
  • Remove deprecated 'default' projectType for jest (in favor of 'custom')
  • Remove deprecated timeoutMs config key
  • Rename packages:
    • stryker => @stryker-mutator/core
    • stryker-xxx-yyy => @stryker-mutator/xxx-yyy
    • stryker-jasmine => @stryker-mutator/jasmine-framework
    • stryker-typescript => @stryker-mutator/typescript
  • Remove config key from being injectable
  • Remove getLogger and setImplementation from stryker-api/logging
  • Remove all deprecated apis/messages/etc
  • Update plugin loader to load plugins from @stryker-mutator (instead of stryker-)
  • Enable lerna versioning mode (not independent, other one)
  • Update stryker-cli to install @stryker-mutator/core instead of stryker and stryker-api
  • Update package.json keywords to @stryker-mutator/
  • Update keyword plugin to 'stryker-mutator-plugin'

Clean up

This original post will be kept up-to-date.

@nicojs
Copy link
Member

nicojs commented Mar 15, 2018

Why would we no longer support mutators as strings? mutator: 'typescript' could be a shorthand for

mutator: {
   type: 'typescript',
   excludedMutations: []
}

@simondel
Copy link
Member Author

simondel commented Mar 15, 2018

I posted that here: #652 (comment)

EDIT: I have removed

  • Remove support for mutators as strings. Only objects will be supported

because that's not the way we will do things as discussed in #652

@simondel
Copy link
Member Author

What about renaming the reporter property of the stryker config to reporters? It's an array after all. We could already implement this with a deprecation warning for people still using the property reporter and remove the reporter property in 1.0.0

@nicojs
Copy link
Member

nicojs commented May 23, 2018

Sounds good. Let's create a separate issue for that

@simondel
Copy link
Member Author

I created #793 and I have updated the main post of this issue

@nicojs
Copy link
Member

nicojs commented May 26, 2018

I've created #799 and updated the main post.

@bartekleon
Copy link
Member

bartekleon commented Aug 13, 2018

@simondel, @nicojs I am trying to solve some easy issues and refactors you need. I am quite newbie in your project, try to understand how it really works, and to understand TS in 100%. Do you have some instructions / tips, how can I work out / find out myself in that big project? You can see some progress in fork

@simondel
Copy link
Member Author

Awesome :) We have a mono-repo. All the stryker plugins that we maintain ourselves are in here. We use Lerna to bind it all together and ensure the packages work together locally. If you run commands such as npm install from the root of the repo, they will be executed in each package.

Perhaps a nice one to start with is this: #1076
It's isolated to two packages which are a lot smaller in size than the main codebase of Stryker 👍 You could either fix both packages in one pull request or split it up into two pull requests. Whatever works for you.

I would also suggest reading the contribution guide if you haven't read it already.

Unfortunately we can't make all the changes for 1.0.0. I'll split the original post up between preparation and execution.

@bartekleon
Copy link
Member

bartekleon commented Aug 13, 2018

@simondel i don't know if you checked what I have done yesterday in fork. I could make pull request today but i have solved #860 and part of the #654 i think. Also did some minor changes to mutators

@bartekleon
Copy link
Member

also i have question about packages/stryker-karma-runner/package.json. In all files you define project [projectType] to be default and then you change it to custom. Is it issue or I missed some line in config

@bartekleon
Copy link
Member

bartekleon commented Aug 13, 2018

I have tried to test but it crashes while testing with one test ->

1) A babel project with the `only` option enabled
       should be able to transpile the input files:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\19gro\Desktop\stryker\packages\stryker-babel-transpiler\test\integration\BabelProjects.it.js)

after next 3 npm run test all testes passed 😛 - it's strange

@simondel
Copy link
Member Author

Since we released it, let's close this :)

@ghost ghost removed the 🛠 In progress label Mar 29, 2019
@nicojs
Copy link
Member

nicojs commented Mar 29, 2019

Are you sure it was well prepared? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants