Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --timeoutMs => --timeoutMS #860

Closed
nicojs opened this issue Jun 6, 2018 · 2 comments
Closed

Rename --timeoutMs => --timeoutMS #860

nicojs opened this issue Jun 6, 2018 · 2 comments
Labels
👶 Good first issue Good for newcomers 🎨 Refactoring

Comments

@nicojs
Copy link
Member

nicojs commented Jun 6, 2018

Casing should be consistent to normal casing rules: --timeoutMS
@simondel
Copy link
Member

simondel commented Jun 8, 2018

Do you want to fix this right away or make the old one deprecated and fix it in 1.0?

@nicojs
Copy link
Member Author

nicojs commented Jun 8, 2018

Yeah, deprecate it first. Remove in 1.0

@nicojs nicojs removed the backlog label Jul 11, 2018
@simondel simondel mentioned this issue Aug 13, 2018
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👶 Good first issue Good for newcomers 🎨 Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicojs @simondel