javascript: fix context menu

Now we no longer need the tab_port.sender field as we pass the pageUrl in the edit message itself.
stsquad · Mar 16, 2019 · 5df9566 · 5df9566
1 parent 01d84d2
commit 5df9566
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/javascript/context_menu.js b/javascript/context_menu.js
@@ -1,15 +1,15 @@
 /* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 (function(){
 
-	var edit_msg = {};
+    var edit_msg = {};
 
-	function menuClicked(info, tab) {
-		if (edit_msg) {
-			var tab_port = chrome.tabs.connect(tab.id);
-			tab_port.sender = { tab: tab };
-			handleContentMessages(edit_msg, tab_port);
-		}
-	}
+    function menuClicked(info, tab) {
+        if (edit_msg) {
+            var tab_port = chrome.tabs.connect(tab.id);
+            edit_msg.pageUrl = info.pageUrl;
+            handleContentMessages(edit_msg, tab_port);
+        }
+    }
 
 
 	var menu_enabled = false;

diff --git a/javascript/xmlcomms.js b/javascript/xmlcomms.js
@@ -93,10 +93,8 @@ function handleContentMessages(msg, tab_port)
     var id = msg.id;
     var text = msg.text;
     var file = msg.file;
-
-    var page_url = tab_port.sender.tab.url;
-    var page_port = tab_port.portId_;
-    console.log(" from page:"+page_url+" and tab port:"+page_port);
+    var page_url = msg.pageUrl;
+    console.log(" from page:"+page_url);
 
     var xhr = new XMLHttpRequest();
     var url = getEditUrl() + cmd;