Make firefox compatible #130

dakra · 2017-07-25T03:19:33Z

So here is the fixes from the other PR #129 rebased and without the formatting changes.
You can pick and choose any commit you want if you want to update in smaller steps.
It's all not heavily tested. More a 'works for me in Firefox', so please test first.

stsquad · 2017-07-25T09:11:21Z

manifest.json

-	"options_page": "fancy-settings/source/index.html",
+	"options_ui": {
+		"page": "fancy-settings/source/index.html",
+		"browser_style": true,


It seems brower_style is Firefox only?

I see only browser_style is not supported which is not really needed anyway. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/options_ui#Browser_compatibility

stsquad · 2017-07-25T09:29:29Z

fancy-settings/source/settings.js

@@ -11,7 +11,7 @@ function localMessageHandler(msg, port) {

 // Test for the presence of an Edit Server
 function test_server() {
-	var port = chrome.extension.connect();
+	var port = browser.runtime.connect();


This breaks on Chrome: Uncaught ReferenceError: browser is not defined
at Object.test_server (settings.js:14)
at Object. (mootools-core.js:1436)
at Array.forEach ()
at Function.forEach (mootools-core.js:211)
at Array.each (mootools-core.js:324)
at Object.fireEvent (mootools-core.js:1434)
at Object.wrapper.extend.$owner (mootools-core.js:1316)
at Object. (setting.js:161)
at HTMLInputElement.defn (mootools-core.js:3703)

So maybe this isn't as cross-platform as it should be

Hmm, https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/connect says it's supported but apparently not :(

stsquad · 2017-07-25T09:30:53Z

@dakra I'm afraid I can't merge this as it breaks in Chrome. I'm quite happy to make the extension cross platform if we can but I can't break it's working case in the process. Please test on both Chrome and Firefox on your next PR.

dakra · 2017-07-25T11:05:56Z

@stsquad I make some shims for the browser calls.
Unfortunately I was not really able to test it in chrome.
I tried to shim it (like now), then I tried mozillas
webextension-polyfill but
all didn't work till I realised even if I checkout your master branch it doesn't
really work (button not appearing). So maybe you check quick?!

Thanks!

stiv-sigmal · 2017-11-12T13:29:25Z

So, how can we use it if Firefox? Any *.xpi files? Any topics on addons.mozilla.org?

stsquad · 2017-11-12T18:06:15Z

I've just tested the master branch on Chrome and it still works. I fixed a minor typo that was throwing up a warning. However with this branch merged all functionality is lost (edit button goes away). Errors include:

 Uncaught ReferenceError: browser is not defined
 Uncaught ReferenceError: browser is not defined

stiv-sigmal · 2017-11-12T18:27:10Z

Is this obstacle to make two different, bun similar extentions for chrome and firefox? To anyone: you, Dakra? As far as I understand, Dakra have made extention for firefox for self, so he has working xpi file. Am I wrong? Or may be I just shoud write direct to Dakra's repository?

stsquad · 2017-11-12T18:28:43Z

@stiv-sigmal I'm sure it's possible but I'm waiting for a tested PR that doesn't break the existing functionality.

dakra · 2017-11-13T00:42:16Z

@stiv-sigmal @stsquad I'll check again the next few days and try to figure out
why chrome is not working.

The "problem" is only that I don't use chrome and don't want to spend too much
time on fixing it so we have a single version that works in both.

Anyway, I'll upload the xpi I'm using daily for Firefox (I'm writing this in
Emacs) so you can at least test it @stiv-sigmal

dakra · 2017-11-13T04:43:56Z

@stsquad @stiv-sigmal ok, I rebased to current master and fixed some things. (now I make a correct typeof browser === 'undefined' check).

In my quick test it worked fine in chrome as well as in firefox.
Attached is the zip for Firefox for @stiv-sigmal
edit_with_emacs-1.14.zip

Since it's unsigned you have to set
xpinstall.signatures.required to false in about:config
(which only works in the developer edition or nightly).

For this zip I added

"applications": {
    "gecko": { "id": "edit-with-emacs@1.14" }
}

to mainfest.json but I think if you upload it to amo it's not necessary (not sure though)

stsquad · 2017-11-18T15:38:05Z

javascript/context_menu.js

@@ -56,7 +56,11 @@
 		sendResponse({});
 	}

-	chrome.extension.onRequest.addListener(processRequest);
+    // Check for Firefox compatibility
+    if (typeof browser === 'undefined') {


How did this work?

That's obviously wrong.

Fixed now.

See https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Browser_support_for_JavaScript_APIs#runtime

zw963 · 2017-11-26T16:17:23Z

Cool, is there any release date for this feature ?

stsquad · 2017-11-26T19:18:19Z

@zw963: well it's merged now - if @dakra is willing to run a test package for firefox I'll tag a release. It's been a while ;-)

dakra · 2017-11-27T09:38:43Z

@stsquad Thanks, good to hear :)

@stiv-sigmal @zw963 Here's the latest version.
I self-signed it so you can easily install it without having to toggle any config flags or having to use Firefox nightly.
(I had to zip it because github doesn't allow me to attach xpi extensions. So unzip and install in firefox)
edit_with_emacs-1.14-an+fx.xpi.gz

It works for me but I guess not very well tested with different setups.
Please try it out and report :)

zw963 · 2017-11-27T15:27:10Z

Hi, It seem like worked for Firefox 48 developer Edition, but have some limit:

if not exist a emacs frame opened, could not create a new frame to edit it when click.
edit button is missing in textarea (tested when reply this issue in github)
when exit current frame when press Ctrl-X Ctrl-S, will invoke edit frame again, repeatly.
I could not exit this edit frame completely, even, when I first edit this reply
in edit frame, after several times Ctrl-X Ctrl-S, what I edit in this edit sever
is override by previous old content, cause many input missing.
when open edit buffer, seem like markdown font-lock is not render correct.

my emacs config

(require 'edit-server)
(setq edit-server-url-major-mode-alist '(
                                         ("github\\.com" . markdown-mode)
                                         ("ruby-china" . markdown-mode)
                                         ("gitlab" . markdown-mode)
                                         )
      edit-server-port "9293"
      )
(when (and (require 'edit-server nil t) (daemonp))
  (edit-server-start)
  (add-hook 'edit-server-start-hook (lambda ()
                                      (local-set-key [(control c) (return)] 'org-ctrl-c-ret)
                                      (local-set-key [(control c) (?\r)] 'org-ctrl-c-ret)
                                      ))
  )

extension config

show edit button. (not work)
alt hotkey (work)

zw963 · 2017-11-27T15:30:20Z

Seem like when I press Ctrl-x Ctrl-s, emacs not response with correct response,
because my textarea is still keep background yellow.
when I move mouse cursor upon little icon in toolbar, I can see:
"Awaiting edit request in focus"

zw963 · 2017-11-27T15:30:53Z

emacs 25.3.1

Thanks

gregoa · 2017-11-27T16:23:28Z

@dakra seems to work for me, thanks! tested on two machines, both running firefox 57, and on both tested at https://paste.debian.net

windows 10, server from http://opencoder.net/edit-server, editor set to notepad++.exe
debian unstable, both with http://opencoder.net/edit-server and pycl.py, editor: a wrapper that calls xterm -e joe

the only minimal glitch I noticed is that the edit button is placed a bit far from the textarea, but that's only cosmetical.

stsquad · 2017-11-27T17:26:15Z

@zw963 those sound like issues with the edit-server. Where do you get your copy from?

stsquad · 2017-11-27T17:27:38Z

@gregoa the img button is now in a

which in theory should make it easier to position with CSS. However this is a little beyond my CSS skills at the moment.

dakra · 2017-11-28T00:28:21Z

if not exist a emacs frame opened, could not create a new frame to edit it
when click.

Hmm, that doesn't happen to me. I can just have the daemon running and
it always pops up a new frame.

edit button is missing in textarea (tested when reply this issue in github)

Oh, now that you say it, it's missing here as well.
I can see the edit button in all other <textarea> inputs though
and it works fine if I click the 'edit in emacs' button from the
toolbar. That's what I use most of the time.
Does it work on other sites?

when exit current frame when press Ctrl-X Ctrl-S, will invoke edit frame again, repeatly.
I could not exit this edit frame completely, even, when I first edit this reply
in edit frame, after several times Ctrl-X Ctrl-S, what I edit in this edit sever
is override by previous old content, cause many input missing.

You can save and close with 'C-c C-c' and discard with 'C-c C-k'.
'C-x C-s' updates the textarea with the current text.
Think the close and reopen of the emacs frame happens in chrome as
well @stsquad?!

when open edit buffer, seem like markdown font-lock is not render correct.

What does not correct mean?
Also I think for github and gitlab at least you want
to set your mode to gfm-mode instead of markdown-mode.

Thanks.

zw963 · 2017-11-28T01:57:46Z

when open edit buffer, seem like markdown font-lock is not render correct.

What does not correct mean?
Also I think for github and gitlab at least you want
to set your mode to gfm-mode instead of markdown-mode.

Sorry, this issue seem like from markdown-mode.

if not exist a emacs frame opened, could not create a new frame to edit it
when click.

Hmm, that doesn't happen to me. I can just have the daemon running and
it always pops up a new frame.

It not worked for me. BTW: I use firefox and emacs on openSUSE 42.3.

@zw963 those sound like issues with the edit-server. Where do you get your copy from?

From this github project. current hash is: 43ec769

stsquad · 2017-11-29T14:46:46Z

@zw963 OK can you raise a separate bug for this. The C-x C-s save behaviour is a little hokey - basically we close the existing session to update the text area and then immediately re-open a new session to continue editing. You might find C-u M-x edit-server-start will give you more indication of what is going on.

zw963 · 2017-11-29T15:13:03Z

@stsquad , hi, i add new issue for C-x C-s, though that maybe not a bug.

DirkSchmitt · 2017-12-04T23:08:58Z

Please release a version to https://addons.mozilla.org/de/firefox/.
It may not be finished, but better to have it then to miss it ;-)

stsquad · 2017-12-07T13:59:25Z

I'm happy for @dakra to upload to the store as he knows about the process.

DirkSchmitt · 2017-12-18T22:07:14Z

I just checked the availability of the extension on https://addons.mozilla.org/de/firefox/ – it is still not available.
@dakra - is there a show stopper ?

zw963 · 2017-12-19T01:43:36Z

Maybe forgot to upload ...

dakra · 2017-12-19T02:38:04Z

@DirkSchmitt sorry, only show stopper is busy Christmas times ;)
I'll upload it later today and post update here.

dakra · 2017-12-19T07:41:44Z

@DirkSchmitt @zw963 https://addons.mozilla.org/en-US/firefox/addon/edit-with-emacs1/

I think invoking the edit via the context menu is somewhat buggy.. I always use
the buttons or M-Enter.

Don't think I have time this year to investigate further.

Also I want to change the addon slug to only 'edit-with-emacs',
AMO said that url was already taken even though I deleted the test upload from
earlier.

zw963 · 2017-12-19T18:10:07Z

I think invoking the edit via the context menu is somewhat buggy.. I always use
the buttons or M-Enter.

me too. always use M-Enter.

This was referenced Jul 25, 2017

Fix deprecated and Firefox incompatible webextension api calls #128

Closed

RFC: Updates and Firefox #129

Closed

stsquad reviewed Jul 25, 2017

View reviewed changes

stsquad added the awaiting-feedback label Jul 25, 2017

dakra force-pushed the emacs_browser branch from 60f7136 to 3528248 Compare July 25, 2017 11:01

anarcat mentioned this pull request Oct 13, 2017

Is a WebExtensions version for Firefox 57+ in the works? docwhat/itsalltext#94

Closed

Update jquery and jquery.color

460632a

dakra force-pushed the emacs_browser branch from 3528248 to dfe9304 Compare November 13, 2017 04:39

stsquad removed the awaiting-feedback label Nov 18, 2017

stsquad reviewed Nov 18, 2017

View reviewed changes

stsquad added the awaiting-feedback label Nov 18, 2017

Fix deprecated and Firefox incompatible webextension api calls

94ac1ba

See https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Browser_support_for_JavaScript_APIs#runtime

dakra force-pushed the emacs_browser branch from dfe9304 to 94ac1ba Compare November 18, 2017 22:56

stsquad merged commit 94ac1ba into stsquad:master Nov 26, 2017

stsquad removed the awaiting-feedback label Nov 29, 2017

zw963 mentioned this pull request Nov 29, 2017

if try to exit editing buffer with Ctrl+X Ctrl+S, will invoke edit frame again. #131

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make firefox compatible #130

Make firefox compatible #130

dakra commented Jul 25, 2017

stsquad Jul 25, 2017

dakra Jul 25, 2017

stsquad Jul 25, 2017

dakra Jul 25, 2017

stsquad commented Jul 25, 2017

dakra commented Jul 25, 2017

stiv-sigmal commented Nov 12, 2017

stsquad commented Nov 12, 2017 •

edited

stiv-sigmal commented Nov 12, 2017

stsquad commented Nov 12, 2017

dakra commented Nov 13, 2017

dakra commented Nov 13, 2017 •

edited

stsquad Nov 18, 2017 •

edited

dakra Nov 18, 2017

zw963 commented Nov 26, 2017

stsquad commented Nov 26, 2017

dakra commented Nov 27, 2017

zw963 commented Nov 27, 2017

zw963 commented Nov 27, 2017

zw963 commented Nov 27, 2017

gregoa commented Nov 27, 2017

stsquad commented Nov 27, 2017

stsquad commented Nov 27, 2017

dakra commented Nov 28, 2017

zw963 commented Nov 28, 2017

stsquad commented Nov 29, 2017

zw963 commented Nov 29, 2017

DirkSchmitt commented Dec 4, 2017

stsquad commented Dec 7, 2017

DirkSchmitt commented Dec 18, 2017

zw963 commented Dec 19, 2017

dakra commented Dec 19, 2017

dakra commented Dec 19, 2017 •

edited

zw963 commented Dec 19, 2017

Make firefox compatible #130

Make firefox compatible #130

Conversation

dakra commented Jul 25, 2017

stsquad Jul 25, 2017

Choose a reason for hiding this comment

dakra Jul 25, 2017

Choose a reason for hiding this comment

stsquad Jul 25, 2017

Choose a reason for hiding this comment

dakra Jul 25, 2017

Choose a reason for hiding this comment

stsquad commented Jul 25, 2017

dakra commented Jul 25, 2017

stiv-sigmal commented Nov 12, 2017

stsquad commented Nov 12, 2017 • edited

stiv-sigmal commented Nov 12, 2017

stsquad commented Nov 12, 2017

dakra commented Nov 13, 2017

dakra commented Nov 13, 2017 • edited

stsquad Nov 18, 2017 • edited

Choose a reason for hiding this comment

dakra Nov 18, 2017

Choose a reason for hiding this comment

zw963 commented Nov 26, 2017

stsquad commented Nov 26, 2017

dakra commented Nov 27, 2017

zw963 commented Nov 27, 2017

my emacs config

extension config

zw963 commented Nov 27, 2017

zw963 commented Nov 27, 2017

gregoa commented Nov 27, 2017

stsquad commented Nov 27, 2017

stsquad commented Nov 27, 2017

dakra commented Nov 28, 2017

zw963 commented Nov 28, 2017

stsquad commented Nov 29, 2017

zw963 commented Nov 29, 2017

DirkSchmitt commented Dec 4, 2017

stsquad commented Dec 7, 2017

DirkSchmitt commented Dec 18, 2017

zw963 commented Dec 19, 2017

dakra commented Dec 19, 2017

dakra commented Dec 19, 2017 • edited

zw963 commented Dec 19, 2017

stsquad commented Nov 12, 2017 •

edited

dakra commented Nov 13, 2017 •

edited

stsquad Nov 18, 2017 •

edited

dakra commented Dec 19, 2017 •

edited