Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fr.json #2182

Closed
wants to merge 1 commit into from
Closed

Update fr.json #2182

wants to merge 1 commit into from

Conversation

LaurieLavoie13
Copy link

No description provided.

IAM-Isabelle-Melnick
IAM-Isabelle-Melnick approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@IAM-Isabelle-Melnick IAM-Isabelle-Melnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Indeed it did not make sense in French to have that last word "pagina", it looks to me like a typo.

@stsrki stsrki changed the base branch from master to sup093 April 9, 2021 06:55
@stsrki stsrki changed the base branch from sup093 to master April 9, 2021 06:55
This was referenced Apr 9, 2021
Merged
Closed
@stsrki
Copy link
Collaborator

stsrki commented Apr 9, 2021

Hi, thank you for fixing it. I would approve it but it should have been done on sup093 branch instead of the master. So it was quicker for me to just recreate it #2183

In any case, I have noted you as a contributor on release notes #1991

Thank you once again!

PS. for future reference https://github.com/stsrki/Blazorise/blob/master/CONTRIBUTING.md

@stsrki stsrki closed this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAM-Isabelle-Melnick IAM-Isabelle-Melnick IAM-Isabelle-Melnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaurieLavoie13 @stsrki @IAM-Isabelle-Melnick