Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DateEdit tests #726

Merged
merged 5 commits into from
Apr 14, 2020
Merged

Added DateEdit tests #726

merged 5 commits into from
Apr 14, 2020

Conversation

DarthPedro
Copy link
Contributor

  • Added unit tests and mock for DateEdit component.
  • Added component level tests for DateEdit as well.
  • Disabled 2 Min-Max tests because they did not work as expected - may be bug in DateEdit component.

@stsrki
Copy link
Collaborator

stsrki commented Apr 14, 2020

I tried the tests and they're failing. It seems the reason is different date formats on your and mine machine.

For example on test SetDateTime() you expect:

<span id=""date-event-initially-undefined-result"">5/3/1970 12:00:00 AM</span>

and on my machine I get the result

<span id="date-event-initially-undefined-result">3.5.1970. 0:00:00</span>

@DarthPedro
Copy link
Contributor Author

Ah, forgot about the possible different date formats. I will fix the tests.

@DarthPedro
Copy link
Contributor Author

I fixed the date formatting issues with the component test expected value strings. Please give it a try.

@stsrki
Copy link
Collaborator

stsrki commented Apr 14, 2020

Everything works now. Good job as always!

@stsrki stsrki merged commit 107c57d into Megabit:dev090 Apr 14, 2020
@stsrki stsrki mentioned this pull request Apr 14, 2020
Closed
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarthPedro @stsrki