Add sysctl patterns to PodSecurityPolicy and admission plugin #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
force-pushed
the
sttts-sysctl-policy
branch
from
40b13ee
to
73496f8
Compare
|
/cc @pweil- could you take a look at these PodSecurityPolicy changes for sysctls? |
|
/cc @hodovska |
| // Sysctls is a white list of allowed sysctls in a pod spec. Each entry | ||
| // is either a plain sysctl name or ends in "*" in which case it is considered | ||
| // as a prefix of allowed sysctls. | ||
| Sysctls []string `json:"sysctls,omitempty"` |
There was a problem hiding this comment.
will * be a use case to allow all sysctls?
There was a problem hiding this comment.
disregard - I see this is covered in the use case. Maybe just need clarification in the comment that * is allowed as a full value and not just a suffix
sttts
force-pushed
the
sysctl-implementation
branch
from
d11013d
to
37b46d1
Compare
sttts
force-pushed
the
sttts-sysctl-policy
branch
from
2f5c168
to
6dc2334
Compare
sttts
pushed a commit
that referenced
this pull request
Aug 5, 2016
- Cannot attach scsi devices to slot #7 - Limit of 4 scsi controllers per vm MAX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.