cmd/server/kube #42
Merged
cmd/server/kube #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
reviewed
Mar 22, 2017
| @@ -26,7 +25,7 @@ func TestKubeletDefaults(t *testing.T) { | |||
| // If the default changes (new fields are added, or default values change), we want to know | |||
| // Once we've reacted to the changes appropriately in BuildKubernetesNodeConfig(), update this expected default to match the new upstream defaults | |||
| expectedDefaults := &kubeletoptions.KubeletServer{ | |||
| AuthPath: flag.NewStringFlag(""), | |||
| //AuthPath: flag.NewStringFlag(""), | |||
sttts
reviewed
Mar 22, 2017
| ) | ||
|
|
||
| func NewSourceAPIOpenShift( |
There was a problem hiding this comment.
Do you plan to merge that somehow with the upstream one?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, ideally we'll just use what's upstream, but it's not available yet.
ncdc
force-pushed
the
sttts-rebase-1.6.0-beta3-cmd-server
branch
from
39ae150
to
47eb8e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.