Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-56] fix(TaiwanLotteryCrawler): migrate the data source to new site #57

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

stu01509
Copy link
Owner

@stu01509 stu01509 commented Jan 3, 2024

  • Bugfix
  • New feature provided
  • Improve performance

描述 Description

FIX #56 Due to a system update in the Taiwan lottery, the original method has become ineffective.

改動 Changes

  • Remove the beautifulsoup4 package.
  • Migrate the data source to new site
  • Update the READMD.md examples

截圖 Screenshot

image

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (da2612a) 74.93% compared to head (3ad51b5) 77.52%.

Files Patch % Lines
TaiwanLottery/__init__.py 89.65% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   74.93%   77.52%   +2.59%     
==========================================
  Files           5        5              
  Lines         367      218     -149     
==========================================
- Hits          275      169     -106     
+ Misses         92       49      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stu01509 stu01509 mentioned this pull request Jan 3, 2024
Copy link

sonarcloud bot commented Jan 4, 2024

@stu01509 stu01509 merged commit 4bec694 into master Jan 4, 2024
4 checks passed
@stu01509 stu01509 deleted the task/56 branch January 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exceptions.SSLError
1 participant