Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddMotifs documentation #1361

Closed
skilpinen opened this issue Mar 27, 2023 · 2 comments
Closed

AddMotifs documentation #1361

skilpinen opened this issue Mar 27, 2023 · 2 comments
Labels
documentation Documentation help

Comments

@skilpinen
Copy link

This maybe just me, but I just cannot find any clue from the documentation how AddMotifs map PWM or PFM into genomic sequence? Like what parameters are used for detection of each location over the genome? Perhaps I am misunderstanding now something, but ain't PFM,PWM just info on each motif, but then actual step of finding each occurrence of these motifs throughout the genome must require some thresholds (=parameters).

@skilpinen skilpinen added the documentation Documentation help label Mar 27, 2023
@timoast
Copy link
Collaborator

timoast commented Mar 28, 2023

Agree we can improve the docs here.

We run motifmatchr (https://bioconductor.org/packages/motifmatchr/) with default parameters to construct a motif x peak matrix using the PFM and genome sequence.

timoast added a commit that referenced this issue Apr 24, 2023
@timoast
Copy link
Collaborator

timoast commented Apr 24, 2023

Now updated on the develop branch

@timoast timoast closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation help
Projects
None yet
Development

No branches or pull requests

2 participants