-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FadeIn / FadeOut not working in Firefox #18
Comments
Hmm, their documentation is pretty useless. Method details on the page return 404s. Have filed a bug. Do you think it's worth removing fadeIn/fadeOut just now? I'm thinking it would be worth make the code base a bit more solid on all browsers before doing fancy stuff like this. |
Saying that, I'm guessing we should handle that if it's easy to detect which parameter is which. We could just swap them around? |
We could detect the browser and swap the arguments... But for what it's worth, those two methods are undocumented and probably won't be used by someone who isn't digging through the source code. Removing them might be the better solution at the moment. re: the documentation. You're right and without the source or the docs it's hard to tell what they're doing. The only way I can infer that the args are switched is because:
|
Cool, have removed them. #21 |
After getting a
SyntaxError: An invalid or illegal string was specified (line 249)
in tests for this line while using the latest version of Firefox, I think I've discovered an issue with Mozilla's implementation of the w3 AudioParam methods.I believe they have reversed the arguments. See: mozilla's documentation vs w3 draft.
I've never filed a bug like this, so until I figure out how, I'm leaving this as a placeholder. @stuartmemo, do you have any input on this?
The text was updated successfully, but these errors were encountered: