Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Sequential to be used in "using"* dependencies #27

Closed
wants to merge 1 commit into from
Closed

allow Sequential to be used in "using"* dependencies #27

wants to merge 1 commit into from

Conversation

mpenet
Copy link

@mpenet mpenet commented Apr 28, 2015

This allows to skip a vec call when building the dependency list dynamically, which imho is a bit more user friendly.

@stuartsierra
Copy link
Collaborator

The canonical form of using dependencies is a map. The vector representation is just syntactic convenience.

Programmatically-generated dependencies should be maps, not sequential collections.

@mpenet
Copy link
Author

mpenet commented May 1, 2015

I find this quite odd since the API specifies maps or vectors (canonical form or not) , and usually unless you require some of the performance/access guarantees of vectors you should allow any Sequential, I have yet to think of a single c.core functions that does this for instance (unless it's a vector op only). Additionally It costs you nothing to allow it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants