Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multifactor authorization flows using Authenticator app and SMS #2274

Merged
merged 56 commits into from Nov 28, 2018
Merged

Enable multifactor authorization flows using Authenticator app and SMS #2274

merged 56 commits into from Nov 28, 2018

Commits on Nov 20, 2018

  1. Factor sign in out from navbar, update styling, enable flows for mult… 

    …ifactor
    @kevinrobinson
    kevinrobinson committed Nov 20, 2018
    Copy the full SHA
    2e8a90f View commit details
    Browse the repository at this point in the history

  2. Fix 1px jump when switching to multifactor

    @kevinrobinson
    kevinrobinson committed Nov 20, 2018
    Copy the full SHA
    5d62c06 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Merge remote-tracking branch 'origin/master' into feature/multifactor… 

    …-plumbing-squashed
    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    b209245 View commit details
    Browse the repository at this point in the history

  2. WIP, hard disk is dying

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    e6e6bdd View commit details
    Browse the repository at this point in the history

  3. Done full pass, no rspecs yet

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    a05ce5d View commit details
    Browse the repository at this point in the history

  4. WIP

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    5e927d9 View commit details
    Browse the repository at this point in the history

  5. Working end-to-end, needs testing all around

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    d7c467e View commit details
    Browse the repository at this point in the history

  6. rel for sign_in fixture

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    2dc00b7 View commit details
    Browse the repository at this point in the history

  7. Model specs

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    747b803 View commit details
    Browse the repository at this point in the history

  8. Add specs for MultifactorAuthenticator

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    63f389a View commit details
    Browse the repository at this point in the history

  9. WIP, tests not done and possible regressions in timing

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    6796d2f View commit details
    Browse the repository at this point in the history

  10. Still in progress with tests

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    991774c View commit details
    Browse the repository at this point in the history

  11. need more work on tests

    @kevinrobinson
    kevinrobinson committed Nov 26, 2018
    Copy the full SHA
    4563883 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2018

  1. Support authenticator app without SMS

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    8a1eda5 View commit details
    Browse the repository at this point in the history

  2. Update specs, add more for MFA

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    9cbc457 View commit details
    Browse the repository at this point in the history

  3. Update controller spec

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    60abf65 View commit details
    Browse the repository at this point in the history

  4. Done masquerade, update FeatureHelpers

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    c27c765 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'patch/remove-shoulda' into feature/multifactor-enabled

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    e46b02e View commit details
    Browse the repository at this point in the history

  6. Throttle multifactor, with tests

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    f6f5ef9 View commit details
    Browse the repository at this point in the history

  7. Updating specs, down to last feature specs

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    3ce1c37 View commit details
    Browse the repository at this point in the history

  8. Update login_timing_feature_spec for multifactor

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    6f66690 View commit details
    Browse the repository at this point in the history

  9. Updated multifactor timing and rack attack feature specs

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    af16223 View commit details
    Browse the repository at this point in the history

  10. Tests all passing

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    1b06f37 View commit details
    Browse the repository at this point in the history

  11. Catch exceptions in ConsistentTiming

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    0f7c213 View commit details
    Browse the repository at this point in the history

  12. Update default timing for multifactor

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    89441aa View commit details
    Browse the repository at this point in the history

  13. Update ENV defaults

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    1d63ba5 View commit details
    Browse the repository at this point in the history

  14. Fix spacing

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    524e8a9 View commit details
    Browse the repository at this point in the history

  15. Merge remote-tracking branch 'origin/master' into feature/multifactor… 

    …-enabled
    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    33b9bf0 View commit details
    Browse the repository at this point in the history

  16. Remove comments

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    d7542ba View commit details
    Browse the repository at this point in the history

  17. Factor out login failure message

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    2954800 View commit details
    Browse the repository at this point in the history

  18. Remove stray sessions table

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    b81db15 View commit details
    Browse the repository at this point in the history

  19. Merge remote-tracking branch 'origin/master' into feature/multifactor… 

    …-enabled
    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    b16dff9 View commit details
    Browse the repository at this point in the history

  20. Add more specs for ConsistentTiming

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    83516a4 View commit details
    Browse the repository at this point in the history

  21. Update some controller specs

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    8fbf240 View commit details
    Browse the repository at this point in the history

  22. Add more MockTwilioClient specs

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    1722dcd View commit details
    Browse the repository at this point in the history

  23. More validations and specs for twilio client and model

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    8b5a132 View commit details
    Browse the repository at this point in the history

  24. Updating multifactor_authenticator specs

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    8471def View commit details
    Browse the repository at this point in the history

  25. ldap_authenticator specs

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    172c9c9 View commit details
    Browse the repository at this point in the history

  26. Update sign_in fixture to correct drift

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    b8af527 View commit details
    Browse the repository at this point in the history

  27. Change MFA copy, add comment on sign_in fixture

    @kevinrobinson
    kevinrobinson committed Nov 27, 2018
    Copy the full SHA
    9775e37 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Add view spec, change button names

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    755e87f View commit details
    Browse the repository at this point in the history

  2. Clean out some more SCSS that is touched, moving to homeroom page

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    648da0c View commit details
    Browse the repository at this point in the history

  3. Move homeroom methods out of Student and into HomeroomsController

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    b8655ef View commit details
    Browse the repository at this point in the history

  4. Remove extra Devise message

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    db60e52 View commit details
    Browse the repository at this point in the history

  5. Optimistic updates, fix bug in multifactor hash

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    0fa8445 View commit details
    Browse the repository at this point in the history

  6. Clean up styles in layout and navbar to isolated them

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    c000188 View commit details
    Browse the repository at this point in the history

  7. Add more explicit test cases for not querying LDAP when multifactor f… 

    …ails
    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    3064b02 View commit details
    Browse the repository at this point in the history

  8. Update form to remove name fields to limit data sent

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    6d6fb59 View commit details
    Browse the repository at this point in the history

  9. Add explicit specs for parameter scrubbing

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    df8ba42 View commit details
    Browse the repository at this point in the history

  10. Add more files to coverage bot

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    60d7712 View commit details
    Browse the repository at this point in the history

  11. Raise timing duration for timing specs

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    78a58cb View commit details
    Browse the repository at this point in the history

  12. Remove autocomplete from all login fields

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    eca3a03 View commit details
    Browse the repository at this point in the history

  13. Update how MockTwilioClient is configured

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    7684ee5 View commit details
    Browse the repository at this point in the history

  14. Scrub all Rollbar logs and add spec to verify

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    a038139 View commit details
    Browse the repository at this point in the history

  15. Make specs more explicit

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    00b65ee View commit details
    Browse the repository at this point in the history

  16. Update spec so that ConsistentTiming reports original error as well

    @kevinrobinson
    kevinrobinson committed Nov 28, 2018
    Copy the full SHA
    db7ad13 View commit details
    Browse the repository at this point in the history