Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access importer: guard against nil values upstream #2380

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Access importer: guard against nil values upstream #2380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/importers/rows/access_row.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def build
)

student_assessment.assign_attributes(
scale_score: row[:assessment_scale_score],
scale_score: parse_or_nil(row[:assessment_scale_score]),
performance_level: row[:assessment_performance_level],
growth_percentile: row[:assessment_growth]
)
Expand All @@ -35,4 +35,9 @@ def subject
return 'Composite' if row[:assessment_subject] == 'Overall'
row[:assessment_subject]
end

# Missing or unparseable values are ignored and converted to nil
def parse_or_nil(value)
if value.nil? || value.to_i == 0 then nil else value.to_i end
end
end