Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in: Preview that sign-in page will change soon #2403

merged 5 commits into from Feb 8, 2019


Copy link

@kevinrobinson kevinrobinson commented Feb 8, 2019

Who is this PR for?


What problem does this PR fix?

There are awesome new designs for the sign-in page, but there's no notice to folks that this will be changing.

What does this PR do?

Adds a notice, with links to previews.

Screenshot (if adding a client-side feature)

screen shot 2019-02-08 at 12 26 43 pm






Which features or pages does this PR touch?

  • Sign in page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Feb 8, 2019


Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Feb 8, 2019

cc @ciscomeneses here's the notification, along with some preview screenshots for folks of how the awesome new designs will look 👍

@kevinrobinson kevinrobinson merged commit 4bbad6d into master Feb 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@kevinrobinson kevinrobinson deleted the feature/sign-in-changes-coming branch Feb 8, 2019
@kevinrobinson kevinrobinson mentioned this pull request Feb 12, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant