Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class list: Expand fix, sort columns, and revised inline profile design #2449

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented May 2, 2019

Who is this PR for?

K8 teaching teams

What problem does this PR fix?

The "expand" button wouldn't work without interaction (maybe react-beautiful-dnd bug from 6.x >
11.x?). This tries to work around.

What does this PR do?

It adds a "sort" button to each column for sorting by name.

It revises the design for the inline profile to match "equity check" categories, and to emphasize notes and humanize more.

Screenshot (if adding a client-side feature)

before

Screen Shot 2019-05-02 at 10 47 40 AM

after

Screen Shot 2019-05-02 at 10 47 07 AM

sorting

Screen Shot 2019-05-02 at 10 50 48 AM

Checklists

Which features or pages does this PR touch?

  • Class lists

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

selfie

@kevinrobinson kevinrobinson merged commit bc28ae8 into master May 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/class-list-expand-and-polish branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.