Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class list: Expand fix, sort columns, and revised inline profile design #2449

merged 3 commits into from
May 2, 2019


Copy link

Who is this PR for?

K8 teaching teams

What problem does this PR fix?

The "expand" button wouldn't work without interaction (maybe react-beautiful-dnd bug from 6.x >
11.x?). This tries to work around.

What does this PR do?

It adds a "sort" button to each column for sorting by name.

It revises the design for the inline profile to match "equity check" categories, and to emphasize notes and humanize more.

Screenshot (if adding a client-side feature)


Screen Shot 2019-05-02 at 10 47 40 AM


Screen Shot 2019-05-02 at 10 47 07 AM


Screen Shot 2019-05-02 at 10 50 48 AM


Which features or pages does this PR touch?

  • Class lists

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

Copy link
Contributor Author


@kevinrobinson kevinrobinson merged commit bc28ae8 into master May 2, 2019
@kevinrobinson kevinrobinson deleted the feature/class-list-expand-and-polish branch May 2, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant