Auditing: Add rails_best_practices checks to Travis build, do cleanup #2703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a subset of https://github.com/flyerhzm/rails_best_practices, does cleanup on the items it found, and adds the check to the Travis build.
These include:
Some other config was just noise, so those are disabled here in
rails_best_practices.yml
.EDIT: I also looked at
UseBeforeFilterCheck
which seems potential useful but is too noisy.This also updates administrate to be more explicit, and limit open routes as helpfully pointed out by
RestrictAutoGeneratedRoutesCheck
.