Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Update F&P thresholds #2775

merged 9 commits into from Feb 28, 2020


Copy link

@kevinrobinson kevinrobinson commented Feb 27, 2020

This is on top of #2774, to avoid churning the snapshot tests (since that PR has some styling changes with wider impact, and this one does with adjusting thresholds).

Who is this PR for?

MTSS facilitators, reading specialists, literacy coaches, K5 classroom teachers

What problem does this PR fix?

This came up with literacy coaches, and so there are some slight revisions to the benchmarks here, but the main intention was to pick these for each of the screening time periods, and extend them out to fifth grade as well. That way if there's screening, there's a way to support highlighting these as well.

What does this PR do?

Updates the thresholds, and then some styling for <ReadingScheduleGrid />, which is used for visualizing the thresholds, and the full raw set of data points over time. Both are intended more for validating data, but the substantive change is that the highlighting in the reader profile will change to match these thresholds. We'll validate this with folks looking at the overall distributions for different cohorts, particularly after this next interval.

Screenshot (if adding a client-side feature)

Screen Shot 2020-02-27 at 4 56 04 PM


Which features or pages does this PR touch?

  • Student Profile
  • Reading thresholds
  • Reading benchmarks by cohort

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

Copy link
Contributor Author

kevinrobinson commented Feb 28, 2020


@kevinrobinson kevinrobinson merged commit a1d8c9c into master Feb 28, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the feature/f-and-p-thresholds branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant