Return actual status codes instead of 400 #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekroTJA
requested changes
Dec 24, 2021
|
There has already an issue for error handling been raised with #28. |
fischor
commented
Dec 24, 2021
|
I would consider this PR to be sufficient for now but I don't want to merge it without @chripo taking a look over it and confirming it before as well. |
zekroTJA
approved these changes
Jan 22, 2022
|
Thank you for reporting and further investigations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status codes sometimes get rewritten to simply 400.
This happens e.g. when on a Write when there is an authentication issue that should actually return code 401.
With this PR the actual status codes are propagated.