Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master with develop #147

Merged
merged 124 commits into from Dec 13, 2018
Merged

Sync master with develop #147

merged 124 commits into from Dec 13, 2018

Conversation

nickcernis
Copy link
Collaborator

Brings master in line with develop ready for the next dev cycle.

vfontjr and others added 30 commits March 30, 2018 12:14
In a clean install, this jQuery produces a reference error for wp not defined. This corrects the error by testing for both wp and wp.customize.
$content_width is a global defined by WP, not the theme.

See #115.
Didn't catch this on the demo until late
Causes an issue with left-aligned text in a center-aligned block and
disguises an issue with center-aligned images.
Using `!important` to make more future proof with other blocks that
may use custom colors. (We will not have to specify every block class
that may use a custom color.)

Fixes #136.
Added to GitHub repo instead.

For #137.
This allows it to be removed from a plugin or from Genesis.

For #139.
Prevents an issue where changing the `CHILD_THEME_NAME` constant stops
the front-end.css stylesheet from being enqueued.

For #141.
Previously, when a custom logo was set and the page was printed,
the custom logo and page title overlap.

For #109.
We're using the genesis_child_* function name in all child themes to
potentially allow Gutenberg features to be unhooked via a plugin or in
Genesis in the future.

See #139.
This is required so the ‘Tags’ line does not fail the max-line-length
rule in the stylelint-config-wordpress we extend from in .stylelintrc.

If stylelint is run when there's space before the ‘Tags’ line, we see
‘Expected line length to be no more than 80 characters’ for that line.

The WordPress stylelint rules contain a pattern to ignore line length
for the stylesheet header, but only if the ‘Tags’ line is not preceded
by white space: https://tinyurl.com/yb3xb5n6.
Using Normal ensures it's selected as the default when opening the
font size drop-down.
@nickcernis nickcernis merged commit af575c1 into master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants