signup signin models added #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitarub
requested changes
Apr 29, 2019
mockServer/index.js
Outdated
| @@ -0,0 +1,35 @@ | |||
| const express = require('express'); | |||
There was a problem hiding this comment.
Убрать mockServer и всё, что с ним связано
| actionName: "SUCCESS_SIGNUP" | ||
| }); | ||
| } catch (error) { | ||
| state["signUp_errorMessage"] = "у нас не получилось залогинить вас в систему" |
There was a problem hiding this comment.
Может здесь просто редиректить на страницу входа?
По этой ошибке внутри компоненты редирект на страницу входа
| @@ -11,11 +11,11 @@ class SignUpValidator { | |||
| if (data.password !== data.passwordRepeat) { | |||
| res.password__errorMessage = "пароли не совпадают"; | |||
| res.passwordRepeat__errorMessage = "пароли не совпадают"; | |||
| res.status = 0; | |||
| res.wasError = 1; | |||
There was a problem hiding this comment.
А может просто error вместо wasError?
There was a problem hiding this comment.
И делать не 1 в ошибке, а нормальный класс ошибки с описанием и т.п?
| @@ -1,6 +1,6 @@ | |||
| const serverUrl = 'http://80.252.155.65:8010/api'; | |||
| const serverUrl = 'http://80.252.155.65:8000/api/v0'; | |||
There was a problem hiding this comment.
Давай вынесем ip в переменную окружения, а то постоянно залетает на гит ?
src/models/authModel.js
Outdated
|
|
||
|
|
||
|
|
||
| // static signUp (userData = {}) { |
| case "USER_SIGNUP": | ||
| SignUpLogic.execLogic(payload,this.state) | ||
| break; | ||
| /** |
There was a problem hiding this comment.
Согласен, лучше отдельно
nikitarub
approved these changes
May 4, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.