Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to tokio 1.0 ecosystem #2

Merged
merged 4 commits into from
Jan 20, 2021
Merged

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Jan 17, 2021

Upgrade to the Tokio 1.0 ecosystem.

@tdyas
Copy link
Contributor Author

tdyas commented Jan 17, 2021

The roundtrip_cancellation test is currently failing with:

test tests::roundtrip_cancellation ... FAILED

failures:

---- tests::roundtrip_cancellation stdout ----
Got connection: PollEvented { io: Some(TcpStream { addr: 127.0.0.1:51041, peer: 127.0.0.1:51044, fd: 38 }) }
thread 'tests::roundtrip_cancellation' panicked at 'assertion failed: `(left == right)`
  left: `ExitCode(-2)`,
 right: `ExitCode(123)`', nails/src/lib.rs:159:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::roundtrip_cancellation

@tdyas
Copy link
Contributor Author

tdyas commented Jan 17, 2021

Interestingly, fixed the hang by using notify_one instead of notify_waiters in ConstantNail. My choice of notify_waiters as if it were a condition variable was not correct. notified apparently only works with notify_one.

@tdyas tdyas marked this pull request as ready for review January 17, 2021 07:00
@stuhood stuhood merged commit 4aa347f into stuhood:master Jan 20, 2021
@stuhood
Copy link
Owner

stuhood commented Jan 20, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants