Skip to content

Commit

Permalink
Deprecate unused --process-execution-local-enable-nailgun (pantsbui…
Browse files Browse the repository at this point in the history
…ld#11600)

While we will likely have something like this code in the future, we can add it back when necessary and possibly tweak it based on the needs then.

[ci skip-build-wheels]
  • Loading branch information
Eric-Arellano committed Feb 25, 2021
1 parent 7de376d commit e19336d
Show file tree
Hide file tree
Showing 10 changed files with 29 additions and 1,254 deletions.
1 change: 0 additions & 1 deletion src/python/pants/engine/internals/native.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ def new_scheduler(
remote_parallelism=execution_options.process_execution_remote_parallelism,
cleanup_local_dirs=execution_options.process_execution_cleanup_local_dirs,
use_local_cache=execution_options.process_execution_use_local_cache,
local_enable_nailgun=execution_options.process_execution_local_enable_nailgun,
remote_cache_read=execution_options.remote_cache_read,
remote_cache_write=execution_options.remote_cache_write,
)
Expand Down
7 changes: 3 additions & 4 deletions src/python/pants/option/global_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ class ExecutionOptions:
process_execution_cache_namespace: Optional[str]
process_execution_cleanup_local_dirs: bool
process_execution_use_local_cache: bool
process_execution_local_enable_nailgun: bool

remote_store_addresses: list[str]
remote_store_headers: Dict[str, str]
Expand Down Expand Up @@ -236,7 +235,6 @@ def from_options(cls, options: Options) -> ExecutionOptions:
process_execution_cleanup_local_dirs=bootstrap_options.process_execution_cleanup_local_dirs,
process_execution_use_local_cache=bootstrap_options.process_execution_use_local_cache,
process_execution_cache_namespace=bootstrap_options.process_execution_cache_namespace,
process_execution_local_enable_nailgun=bootstrap_options.process_execution_local_enable_nailgun,
# Remote store setup.
remote_store_addresses=remote_store_addresses,
remote_store_headers=remote_store_headers,
Expand Down Expand Up @@ -272,7 +270,6 @@ def from_options(cls, options: Options) -> ExecutionOptions:
process_execution_cache_namespace=None,
process_execution_cleanup_local_dirs=True,
process_execution_use_local_cache=True,
process_execution_local_enable_nailgun=False,
# Remote store setup.
remote_store_addresses=[],
remote_store_headers={},
Expand Down Expand Up @@ -811,9 +808,11 @@ def register_bootstrap_options(cls, register):
register(
"--process-execution-local-enable-nailgun",
type=bool,
default=DEFAULT_EXECUTION_OPTIONS.process_execution_local_enable_nailgun,
default=False,
help="Whether or not to use nailgun to run the requests that are marked as nailgunnable.",
advanced=True,
removal_version="2.5.0.dev0",
removal_hint="This option no-ops as Pants does not yet support the JVM.",
)

register(
Expand Down
2 changes: 0 additions & 2 deletions src/rust/engine/process_execution/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ pub mod remote_cache;
#[cfg(test)]
mod remote_cache_tests;

pub mod nailgun;

pub mod named_caches;

extern crate uname;
Expand Down
294 changes: 0 additions & 294 deletions src/rust/engine/process_execution/src/nailgun/mod.rs

This file was deleted.

0 comments on commit e19336d

Please sign in to comment.