Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With schedules #72

Merged
merged 31 commits into from
Aug 21, 2022
Merged

With schedules #72

merged 31 commits into from
Aug 21, 2022

Conversation

stulp
Copy link
Owner

@stulp stulp commented Aug 9, 2022

This branch implements the new DmpWithSchedules class.
https://github.com/stulp/dmpbbo/blob/with_schedules/dmpbbo/dmps/DmpWithSchedules.py

It also includes a demo that shows how gains are optimized in stochastic and constant force fields:
https://github.com/stulp/dmpbbo/blob/with_schedules/demos/python/bbo_of_dmps/with_schedules/README.md

Copy link
Collaborator

@ignacio-pm ignacio-pm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python implementation looks well-coded and usable. Demo and README help understand the changes. However, I do not have a major knowledge on how the whole implementation in Python works and I have not tested it. Some minor comments are written in the review.

dmpbbo/dmps/DmpWithSchedules.py Outdated Show resolved Hide resolved
dmpbbo/dmps/DmpWithSchedules.py Show resolved Hide resolved
dmpbbo/dmps/DmpWithSchedules.py Show resolved Hide resolved
@stulp
Copy link
Owner Author

stulp commented Aug 21, 2022

Thank you @ignacio-pm for the code review! Especially for pointing out features of the code that should be improved in several classes, beyond the ones in this PR.

@stulp stulp merged commit 7860fe6 into master Aug 21, 2022
@stulp stulp deleted the with_schedules branch August 21, 2022 09:34
@ignacio-pm
Copy link
Collaborator

Thank you for creating and maintaining this repository! I do not plan to use it again in the short term, but many people will find it helpful.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants