Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[winner-mode] Winner mode seems broken on stumpwm master #189

Closed
lepisma opened this issue Apr 5, 2020 · 1 comment
Closed

[winner-mode] Winner mode seems broken on stumpwm master #189

lepisma opened this issue Apr 5, 2020 · 1 comment

Comments

@lepisma
Copy link
Contributor

lepisma commented Apr 5, 2020

While calling winner-mode:dump-group-to-file, we see this

The value
  #P\"/tmp/stumpwm-winner-mode-1-0000000017\"
is not of type
  (OR SB-IMPL::PATTERN (VECTOR CHARACTER) (VECTOR NIL)
      BASE-STRING (MEMBER NIL :UNSPECIFIC :WILD))

when binding SB-IMPL::NAME

The way stumpwm::dump-to-file is defined on stump master doesn't work well with the absolute path that winner-mode uses. Here is the commit that possibly causes this. See this issue for more details on the change.

A possible fix would be to change winner mode to accept the home directory dumping change but since these dumps are supposed to be temporary, I am not sure if this will be the best thing to do.
landakram added a commit to landakram/stumpwm that referenced this issue Feb 8, 2021
@landakram
Allow absolute paths when dumping and restoring dumps
4ec2293 
If the name passed into various dump commands is an absolute path, it will be used as
is. Otherwise, it will default to XDG_DATA_HOME/stumpwm/NAME.dump, as previously
implemented to resolve stumpwm#746. The prior behavior also broke winner-mode, which
dumps in /tmp/.

Tested:

* winner-mode works as expected (absolute path)
* Interactively dumping with `dump-group` and `restore-group` with a name works as expected

Fixes:

* stumpwm/stumpwm-contrib#189
* stumpwm#746
@landakram landakram mentioned this issue Feb 8, 2021
Merged
@lepisma
Copy link
Contributor Author

lepisma commented Jun 14, 2022

This issue is resolved, thanks to @landakram . Winner mode is working on stumpwm master.

@lepisma lepisma closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lepisma