Refactor make-screen-heads #344
Conversation
| (setf (head-number head) | ||
| (incf head-index)))) | ||
| (mapc #'set-head-number heads)))) | ||
|
|
There was a problem hiding this comment.
(loop for head in heads
for i upfrom 0
do (setf (head-number head) i))
There was a problem hiding this comment.
@Harleqin Yes, that is the code being replaced with a mapc, because it has a higher information density. Ideally I'd use misc-extensions's rflet so the flet would be at the end instead of cluttering the relevant code. Do you think the loop version is more readable in this case?
There was a problem hiding this comment.
Yes, absolutely, it also feels more declarative to me.
There was a problem hiding this comment.
Honestly the flet+incf+mapc seems like scratching your nose behind your head to keep it functional. The operation is inherently declarative and its easier to mentally parse the loop version.
There was a problem hiding this comment.
K, I'll go back to using loop
Refactor make-screen-heads
This is just a refactor or the current head implemenatation to make it more readable. It is a first stop towards #328, which seems to have gone cold