Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page.go ought to return a Promise #26

Closed
pmowrer opened this issue Feb 24, 2015 · 0 comments
Closed

Page.go ought to return a Promise #26

pmowrer opened this issue Feb 24, 2015 · 0 comments

Comments

@pmowrer
Copy link

pmowrer commented Feb 24, 2015

The method it wraps, browser.get, returns a Promise (though undocumented). I find myself needing this quite often, e.g. doing browser.pause()following a page load.
pmowrer added a commit to pmowrer/astrolabe that referenced this issue Feb 24, 2015
@pmowrer
Return Promise from Page.go
14794f2 
The method it wraps, browser.get, returns a Promise (though
undocumented).

Fixes stuplum#26
pmowrer added a commit to pmowrer/astrolabe that referenced this issue Feb 24, 2015
@pmowrer
Return Promise from Page.go
35a25f0 
The method it wraps, browser.get, returns a Promise (though
undocumented).

Fixes stuplum#26
@pmowrer pmowrer mentioned this issue Feb 24, 2015
Closed
@pmowrer pmowrer closed this as completed Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return Promise from Page.go pmowrer/astrolabe
1 participant
@pmowrer