Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructors for mutex and condition_variable wrongly noexcept #60

Closed
niklas88 opened this issue May 3, 2017 · 0 comments
Closed

Destructors for mutex and condition_variable wrongly noexcept #60

niklas88 opened this issue May 3, 2017 · 0 comments

Comments

@niklas88
Copy link
Contributor

niklas88 commented May 3, 2017

Compiling with g++ 6.3.1 I get the following warnings

error.txt

it seems to me that these are genuine and that ~mutex() and ~condition_variable() may indeed throw while being assumed noexcept by C++11 rules. I'm not an expert on this but adding the relevant noexcept(false) declarations as well as some follow ups fixes the warning. These changes are available as a pull request of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant