-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a simpler hashing algorithm when a file system is available #112
use a simpler hashing algorithm when a file system is available #112
Conversation
c1173a2
to
44ee2b0
Compare
|
a9ebe59
to
77bff83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good in terms of the code that changed, but the snapshot change is making it very hard to review what exactly this affects/if it works. 😕
@mxstbr even with the separate commits? I'll merge the whitespace serializer back into the first two commits to make it as clear as possible |
0ca7cb5
to
deaac56
Compare
deaac56
to
013146b
Compare
@mxstbr I ended up dropping the rename from |
013146b
to
a1a72e0
Compare
for easier diffing
a1a72e0
to
25880f1
Compare
There we go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @philpl? Any reasons why we shouldn't do it this way?
25880f1
to
5bfcbd7
Compare
Shipping this and the ref styled-components PR! styled-components/styled-components#1381 |
fixes #105
By not including the file contents in the hash, the generated IDs
should be more durable and less susceptible to minor differences
in file content due to a babel plugin being applied to ssr vs
client config or something like that