Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used a simpler hashing strategy when a file system is available #498

Merged
merged 2 commits into from
Dec 21, 2017
Merged

used a simpler hashing strategy when a file system is available #498

merged 2 commits into from
Dec 21, 2017

Conversation

quantizor
Copy link
Contributor

@quantizor quantizor commented Dec 20, 2017

avoiding the file contents when hashing helps alleviate some pains
that can occur if build environments make subtle changes, like running
a particular loader for an SSR build that changes unrelated code

this is the same as styled-components/babel-plugin-styled-components#112

@quantizor quantizor changed the title used a simplified hashing strategy when a file system is available used a simpler hashing strategy when a file system is available Dec 21, 2017
@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #498 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/babel-plugin-emotion/test/util.js 100% <ø> (ø) ⬆️
packages/babel-plugin-emotion/src/index.js 96.4% <100%> (+0.08%) ⬆️

avoiding the file contents when hashing helps alleviate some pains
that can occur if build environments make subtle changes, like running
a particular loader for an SSR build that changes unrelated code
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I disagree with this since it could encourage people to rely on the class in snapshots and other places, I think we should just do it.

@tkh44 tkh44 self-requested a review December 21, 2017 19:19
@emmatown emmatown merged commit 301c724 into emotion-js:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants