-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rgba): Fade color with rgba module #168
Conversation
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 64 64
Lines 347 350 +3
Branches 97 98 +1
=====================================
+ Hits 347 350 +3
Continue to review full report at Codecov.
|
Still not a fan, Nevertheless the PR looks good. One open question: Should we allow strings then rgb as well? If not that seems to be pretty inconsistent. |
@nikgraf I've been kinda torn on this one myself. There are a couple things at play here.
Which still leaves us with the question of, is there a solution that accomplishes these things without making us feel bad about including it in the library? Can you give me an example of what you mean when you say :
|
Hmm, I can't remember what I meant by strings, but the PR looks good to me. If we haven't found a better solution after that time I think the best course of action is to merge it :) Can we merge this now or should it be 2.0? Afaik it's not a breaking change. |
This is not a breaking change, so I'm fine with merging it. |
rgba now can accept a hex or named CSS color value and an alpha value to fade a color
rgba now can accept a hex or named CSS color value and an alpha value to fade a color.
Addresses request made in #104