Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rem helper #35

Merged
merged 10 commits into from
Dec 16, 2016
Merged

Add rem helper #35

merged 10 commits into from
Dec 16, 2016

Conversation

mxstbr
Copy link
Member

@mxstbr mxstbr commented Dec 8, 2016

Adds the rem helper

This is 100% based on the em helper from #34

@mxstbr mxstbr mentioned this pull request Dec 8, 2016
50 tasks
@mxstbr
Copy link
Member Author

mxstbr commented Dec 13, 2016

Updated to be exactly like the just merged em helper, then realized that they basically look exactly the same. I created a _pxto factory which allows us to very easily create those two with almost no code repetition. (except documentation)

Also moved all the tests over there. Feel free to review!

@codecov-io
Copy link

codecov-io commented Dec 14, 2016

Current coverage is 100% (diff: 100%)

Merging #35 into master will not change coverage

@@           master   #35   diff @@
===================================
  Files          13    13          
  Lines          41    42     +1   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
+ Hits           41    42     +1   
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 6b7b758...5a7ba18

@mxstbr mxstbr merged commit b081e6c into master Dec 16, 2016
@mxstbr mxstbr deleted the rem-helper branch December 16, 2016 10:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants