Border, Padding, and Margin shorthands #56
Conversation
bhough
force-pushed
the
directional-helper
branch
from
f55755b
to
4334e4a
Compare
|
@mxstbr Wanted to get your eyes on this implementation before I wrote up the docs for it. |
|
Looks really good from a first glance! 😱 |
bhough
force-pushed
the
directional-helper
branch
2 times, most recently
from
7043d14
to
165cc6a
Compare
Current coverage is 100% (diff: 100%)@@ master #56 diff @@
===================================
Files 21 28 +7
Lines 84 107 +23
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 84 107 +23
Misses 0 0
Partials 0 0
|
| * } | ||
| */ | ||
|
|
||
| function position(positionKeyword: string|null, ...values: Array<string|null>) { |
There was a problem hiding this comment.
If you set null as a type flow will think that's an any, which we need to avoid. Instead of saying that, do param: ?string. That'll tell flow that the param is null-able!
| * } | ||
| */ | ||
|
|
||
| function padding(...values: Array<string|null>) { |
There was a problem hiding this comment.
If you set null as a type flow will think that's an any, which we need to avoid. Instead of saying that, do param: ?string. That'll tell flow that the param is null-able!
| * } | ||
| */ | ||
|
|
||
| function margin(...values: Array<string|null>) { |
There was a problem hiding this comment.
If you set null as a type flow will think that's an any, which we need to avoid. Instead of saying that, do param: ?string. That'll tell flow that the param is null-able!
| return splitPropertyName.join('-') | ||
| } | ||
|
|
||
| function generateStyles(property: string, valuesWithDefaults: Array<string|null>) { |
There was a problem hiding this comment.
If you set null as a type flow will think that's an any, which we need to avoid. Instead of saying that, do param: ?string. That'll tell flow that the param is null-able!
| * } | ||
| */ | ||
|
|
||
| function borderColor(...values: Array<string|null>) { |
There was a problem hiding this comment.
If you set null as a type flow will think that's an any, which we need to avoid. Instead of saying that, do param: ?string. That'll tell flow that the param is null-able!
| * } | ||
| */ | ||
|
|
||
| function borderStyle(...values: Array<string|null>) { |
There was a problem hiding this comment.
If you set null as a type flow will think that's an any, which we need to avoid. Instead of saying that, do param: ?string. That'll tell flow that the param is null-able!
| * } | ||
| */ | ||
|
|
||
| function borderWidth(...values: Array<string|null>) { |
There was a problem hiding this comment.
If you set null as a type flow will think that's an any, which we need to avoid. Instead of saying that, do param: ?string. That'll tell flow that the param is null-able!
| * } | ||
| */ | ||
|
|
||
| function directionalProperty(property: string, ...values: Array<string|null>) { |
There was a problem hiding this comment.
If you set null as a type flow will think that's an any, which we need to avoid. Instead of saying that, do param: ?string. That'll tell flow that the param is null-able!
Shorthand helpers for border-width, border-color, border-style, margin, padding, and the general directionalProperty helper
Added docs for new shorthands, added flow to test files misssing it, added npm run docs command to serve docs locally, fixed doc typos
bhough
force-pushed
the
directional-helper
branch
from
7b30e5c
to
e1feb49
Compare
|
@mxstbr should be good now. |
|
I'm seeing some totally unrelated commits we already have in master here?
|
|
Odd I'm not seeing those, let me re-push the rebase onto master and see if that fixes it for ya. |
bhough
force-pushed
the
directional-helper
branch
from
e1feb49
to
c26de2c
Compare
Update types on directional shorthands to properly show values array elements are nullable.
bhough
force-pushed
the
directional-helper
branch
from
c26de2c
to
05215d3
Compare
|
k @mxstbr did another force push of my branch. I've had some wonkiness going on with my pushes today, as I'm working from Taiwan and the connection isn't always stable. Hopefully that fixed it. |
|
Awesomeeee!! |
Shorthand helpers for border-width, border-color, border-style, margin, padding, and the general directionalProperty helper.