-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add site search #85
Comments
@mxstbr I checked Flow and it's using Algolia. How do you want results to be? I think Flow results box are a bit overhead for styled-components, isn't it? I'd like to implement it. |
I quite like the flow result box, but feel free to experiment and come up with something better! |
I found this: https://github.com/algolia/docsearch I'm pretty sure it's what Webpack, Babel, React and others use. How is it? |
Let's do it! |
Sounds great! |
This is the reply I got from Algolia team (I thought it's good to have it here too): Hi Mohammad, Congratulations, your search is now ready! You're now a few steps away from having it working on your website:
Feel free to get back to us if you have any issues or questions regarding the integration. Have a nice day :) I'll try setting it up tomorrow. |
👌 |
@morajabi need any help getting this wrapped up? |
This was done actually, but I think we had a minor problem on mobile and we hold it? @mxstbr Am I recalling correctly? |
Fixed as of #310 |
I love how the React and Flow docs do their search, I think that's using Algolia? We should have the search input on every page, so it'll likely have to sit in the nav bar at the top, ref #83.
For now it'd be fine to only live on docs pages in the sidebar though, don't let yourself be blocked by #83!Update: There's a search component ready for the nav bar.
The text was updated successfully, but these errors were encountered: