Change 'too many classes' error to recommend attrs for frequently changed styles #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
lukebelliveau
changed the title
kitten
previously requested changes
Oct 7, 2017
| console.warn(`Over ${LIMIT} classes were generated for component ${displayName}. ` + | ||
| 'Consider using style property for frequently changed styles.\n' + | ||
| console.warn(`Over ${LIMIT} classes were generated for component ${displayName}. \n` + | ||
| 'Consider using the attrs property, together with a style object for frequently changed styles.\n' + |
There was a problem hiding this comment.
*attrs property => method
Otherwise lgtm :)
mxstbr
requested changes
Oct 8, 2017
There was a problem hiding this comment.
Great work @lukebelliveau, thank you for all these contributions! One tiny nitpick then we'll ship this 👌
| ' const StyledComp = styled.div`width: 100%;`\n' + | ||
| ' <StyledComp style={{ background: background }} />') | ||
| ' const Component = styled.div.attrs({\n' + | ||
| ' style: ({ background }) => {\n' + |
There was a problem hiding this comment.
There is a pair of parenthesis missing here:
style: ({ background }) => {
background,
}
// should be
style: ({ background }) => ({
background,
})
This was referenced Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.