Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ThemeProvider error straightforward #2787

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

lekterable
Copy link
Member

Super small change, just for the sake of keeping errors dead simple and straightforward.
I think that theres a chance that it might save someone a bit of confusion.

@quantizor
Copy link
Contributor

quantizor commented Oct 14, 2019

This is unfortunately a breaking change. We can't accept this for v4 or v5, but can consider it for v6. nevermind, I see this is just making a more-clear error. Ok cool.

Can you do this for canary instead?

@lekterable lekterable changed the base branch from master to canary October 14, 2019 20:56
@lekterable
Copy link
Member Author

that should do it, let me know what you think @probablyup

does the sandbox work on the canary btw? when I'm trying to access the page after yarn start and installing the modules I get:

Zrzut ekranu 2019-10-14 o 22 55 26

I've tried on the clean branch as well so It's not because of my changes.

@quantizor
Copy link
Contributor

quantizor commented Oct 22, 2019

@lekterable ah yeah just run build first (from root I think) so it generates the file locally

@quantizor quantizor added the 5.0 label Oct 22, 2019
@lekterable
Copy link
Member Author

yup, that did it, thanks @probablyup ! I've tried it in sandbox on canary and works as expected so It's ready to merge! :)

Zrzut ekranu 2019-10-23 o 00 03 01

Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@quantizor quantizor merged commit 95bb33a into styled-components:canary Oct 22, 2019
@lekterable lekterable deleted the simple-error branch October 22, 2019 22:06
This was referenced Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants