Skip to content
This repository has been archived by the owner on Jun 30, 2024. It is now read-only.

fix Incorrect cursor position after css autocomplete #362

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix Incorrect cursor position after css autocomplete #362

merged 1 commit into from
Mar 9, 2022

Conversation

zqy233
Copy link
Contributor

@zqy233 zqy233 commented Mar 6, 2022

fix #360

@jasonwilliams
Copy link
Collaborator

Thanks @zqy233 will take a look soon

@jasonwilliams
Copy link
Collaborator

Thanks for your PR @zqy233

@jasonwilliams jasonwilliams merged commit 95fa2a7 into styled-components:master Mar 9, 2022
@GusPrado GusPrado mentioned this pull request Sep 1, 2022
Closed
@GusPrado
Copy link

GusPrado commented Sep 1, 2022

Unfortunately not completely fixed as recent discussion confirms on #360

@zqy233
Copy link
Contributor Author

zqy233 commented Sep 1, 2022

Unfortunately not completely fixed as recent discussion confirms on #360

It seems to be OK on my Windows computer. I can't test it on MAC for the time being，Can you try to fix it？
the code in src/insertColonCommand.ts caused this problem，you can "git clone" this project and "npm i"，then "npx vsce package"，test the generated vsix file

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect cursor position after css autocomplete
3 participants
@zqy233 @jasonwilliams @GusPrado