Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sections with href are always opening in new tabs #1559

Closed
iSysProc opened this issue Mar 14, 2020 · 4 comments
Closed

Sections with href are always opening in new tabs #1559

iSysProc opened this issue Mar 14, 2020 · 4 comments
Labels
bug help wanted released

Comments

@iSysProc
Copy link

image

Section field 'external' don't affect on shouldOpenInNewTab

Maybe change this row on: shouldOpenInNewTab: section.external && !!section.href, ?
@sapegin
Copy link
Member

sapegin commented Mar 14, 2020

Feel free to send a pull request with a fix 👾

@mitsuruog
Copy link
Contributor

What is the correct and intended behavior?

@sapegin
Copy link
Member

sapegin commented Mar 16, 2020

external should define the behavior if present. We probably can remove the magic that opens all sections with href in the new tab by default. At least the docs and the examples would be correct in this case:

https://react-styleguidist.js.org/docs/components.html

@mitsuruog mitsuruog mentioned this issue Mar 17, 2020
Merged
@styleguidist-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 11.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sapegin @mitsuruog @iSysProc @styleguidist-bot