Fix Sections with href are always opening in new tabs #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuruog
commented
Mar 17, 2020
| @@ -76,7 +76,7 @@ export default class TableOfContents extends Component<TableOfContentsProps> { | |||
| heading: !!section.name && children.length > 0, | |||
| content, | |||
| selected, | |||
| shouldOpenInNewTab: !!section.href, | |||
| shouldOpenInNewTab: !!section.external && !!section.href, | |||
There was a problem hiding this comment.
external is an optional field.
undefined && true gives undefined, so I make force boolean cast here.
Codecov Report
|
|
Thanks! |
|
🎉 This PR is included in version 11.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved.
The section does not open in the new tab unless
hrefandexternalhas set both.please review me.