Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Severity Security Vulnerability: markdown-to-jsx #1596

Closed
evadecker opened this issue May 20, 2020 · 4 comments
Closed

High Severity Security Vulnerability: markdown-to-jsx #1596

evadecker opened this issue May 20, 2020 · 4 comments

Comments

@evadecker
Copy link
Contributor

There is currently a high severity security vulnerability in the markdown-to-jsx package used by Styleguidist.

https://npmjs.com/advisories/1219

All versions of simple-markdown are vulnerable to Cross-Site Scripting. Due to insufficient input sanitization the package may render output containing malicious JavaScript. This vulnerability can be exploited through input of links containing data or VBScript URIs and a base64-encoded payload.

This vulnerability is now preventing our company from using Styleguidist to document components, as we run npm audit to ensure that our codebase is secure.

@gbhasha
Copy link

gbhasha commented May 21, 2020

Yes. We do have same problem and vulnerable packages are not allowed as per company policy.

image

@gbhasha
Copy link

gbhasha commented May 21, 2020

@sapegin
Copy link
Member

sapegin commented May 25, 2020

Feel free to send a pull request with a fix.

@evadecker
Copy link
Contributor Author

It appears that this has been resolved: quantizor/markdown-to-jsx#306 (comment) and the package maintainers are just waiting on npm to approve that the vulnerability has been patched.

I've opened a PR to update the markdown-to-jsx version here: #1599

sapegin pushed a commit that referenced this issue May 27, 2020
This updates the markdown-to-jsx package to v6.11.4 in order to patch a security vulnerability as reported at #1596 and addressed here at quantizor/markdown-to-jsx#306
@sapegin sapegin closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants