Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back / forward browser buttons don’t work properly #467

Closed
sapegin opened this issue Jun 6, 2017 · 1 comment
Closed

Back / forward browser buttons don’t work properly #467

sapegin opened this issue Jun 6, 2017 · 1 comment
Assignees
@sapegin
Labels
bug help wanted
Milestone
6.1.0

Comments

@sapegin
Copy link
Member

sapegin commented Jun 6, 2017

Was found by @n1313:

  1. Click on "open isolated" button for the first example of the Button component.
  2. Click "back" in the browser — see that the "Lick me" example is no longer displayed on the page, and that the "open isolated" button for the first example has the wrong icon.
  3. Click "forward" in the browser — the page shifts to the left (??) and nothing happens.

There is also an error in the console:

main.bundle.js:26222 Uncaught TypeError: Cannot read property 'type' of undefined

We may need to introduce some proper routing to fix this kind of issues. I don’t mean React Rooter, but something very simple but isolated, not hardcoded in the index.js.
@sapegin sapegin added the bug label Jun 6, 2017
@sapegin sapegin mentioned this issue Jun 12, 2017
Closed
@sapegin
Copy link
Member Author

sapegin commented Nov 7, 2017

Routing is a big issue described in #494 but we can probably fix an error here.

@sapegin sapegin mentioned this issue Nov 7, 2017
Closed
@sapegin sapegin added this to the 6.1.0 milestone Nov 7, 2017
sapegin added a commit that referenced this issue Nov 7, 2017
@sapegin
Fix: Navigation between list and isolated mode issues
c4910c5 
1. Navigate to isolated example and back: you’ll see only this one
example, not all of them.
2. Navigate to isolated example of a component with only one example:
you’ll see isolated mode button below this example instead of a show
all components button.

Closes #663, #467
@sapegin sapegin mentioned this issue Nov 7, 2017
Closed
@sapegin sapegin self-assigned this Nov 7, 2017
sapegin added a commit that referenced this issue Nov 9, 2017
@sapegin
Fix: Navigation between list and isolated mode issues
32db130 
1. Navigate to isolated example and back: you’ll see only this one
example, not all of them.
2. Navigate to isolated example of a component with only one example:
you’ll see isolated mode button below this example instead of a show
all components button.

Closes #663, #467
@sapegin sapegin closed this as completed Nov 9, 2017
This was referenced Jun 2, 2020
Open
Open
@Bhanditz Bhanditz mentioned this issue Mar 15, 2021
Open
@kopax kopax mentioned this issue Mar 15, 2021
Open
@Bhanditz Bhanditz mentioned this issue Nov 5, 2022
Open
@kopax kopax mentioned this issue Nov 5, 2022
Open
@Bhanditz Bhanditz mentioned this issue Dec 25, 2022
Open
@kopax kopax mentioned this issue Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sapegin sapegin

Labels
bug help wanted
Projects
None yet
Milestone
6.1.0
Development

No branches or pull requests
1 participant
@sapegin