Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve terminal output on style guide server start #470

Closed
3 tasks
sapegin opened this issue Jun 7, 2017 · 12 comments
Closed
3 tasks

Improve terminal output on style guide server start #470

sapegin opened this issue Jun 7, 2017 · 12 comments
Labels

Comments

@sapegin
Copy link
Member

sapegin commented Jun 7, 2017

I like how it’s done in Create React App:

  • Show the URL only after successful compilation
  • Show network URL
  • Improve the UI

Most likely we can reuse some functions from react-dev-utils (we already use it in Styleguidist), then this task will be relatively easy ;-)

@sapegin sapegin added good first issue Good for newcomers help wanted labels Jun 7, 2017
@SaraVieira
Copy link
Collaborator

screenshot 2017-06-11 10 33 09

In this case what is the lan URL ?

@sapegin
Copy link
Member Author

sapegin commented Jun 11, 2017

Take a look at CRA implementation (link in the description), they have all the code (and we probably can reuse it).

@SaraVieira
Copy link
Collaborator

SaraVieira commented Jun 11, 2017 via email

@SaraVieira
Copy link
Collaborator

SaraVieira commented Jun 11, 2017 via email

@sapegin
Copy link
Member Author

sapegin commented Jun 11, 2017

Try to reuse their code first ;-)

@SaraVieira
Copy link
Collaborator

Oh yeah , i'm still on master , just want to show the ui before I start working on it and get that approved first :)
screenshot 2017-06-11 16 40 09

@sapegin
Copy link
Member Author

sapegin commented Jun 11, 2017

Looks cool! Could we remove this npm run compile notice? It’s incorrect anyway ;-)

  • Style guide → style guide
  • On Your Network → On your network

@SaraVieira
Copy link
Collaborator

SaraVieira commented Jun 11, 2017 via email

@sapegin
Copy link
Member Author

sapegin commented Jun 11, 2017

Sounds good, thanks! 🍕

@sapegin
Copy link
Member Author

sapegin commented Jul 24, 2017

@SaraVieira Do you have anything to pull request here? ;-)

@SaraVieira
Copy link
Collaborator

Damn @sapegin no :(
I'll get on this tomorrow, I'll use my new cli skills to make it awesome! 🎉🎉

Sent from my Bq Aquaris M5 using FastHub

snmslavk added a commit to snmslavk/react-styleguidist that referenced this issue Aug 29, 2017
snmslavk added a commit to snmslavk/react-styleguidist that referenced this issue Aug 29, 2017
snmslavk added a commit to snmslavk/react-styleguidist that referenced this issue Aug 29, 2017
… message; remove redundant parameters condition
snmslavk added a commit to snmslavk/react-styleguidist that referenced this issue Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants