adds inline-scroll on props-table #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the "Pathline" breaks the responsive view if it gets too long as there will be a horizontal scrollbar
…uidist into feature/table-overflow
sapegin
requested changes
Sep 7, 2018
| tabBody: { | ||
| overflowX: 'auto', | ||
| maxWidth: '100%', | ||
| '-webkit-overflow-scrolling': 'touch', |
There was a problem hiding this comment.
Will WebkitOverflowScrolling work too?
There was a problem hiding this comment.
Sure, yes. :-) However it is the same as here:
- but I am not super into styled-components, so I don't really know what's the intended way to do it. Btw.: Thanks for your great work on it so far!There was a problem hiding this comment.
Both should work the same way, camelCased one is just more idiomatic, because all other attributes are camelCased.
It's JSS, not styled-components by the way ;-)
|
And please update snapshots too ;-) |
sapegin
reviewed
Sep 11, 2018
| @@ -37,7 +37,7 @@ const styles = ({ color, fontFamily, fontSize, sidebarWidth, mq, space, maxWidth | |||
| bottom: 0, | |||
| width: sidebarWidth, | |||
| overflow: 'auto', | |||
| '-webkit-overflow-scrolling': 'touch', | |||
| WebkitOverflowScrolling: 'touch', | |||
sapegin
approved these changes
Sep 11, 2018
|
Thanks for fixing these small details! ❤️ |
|
🎉 This PR is included in version 7.3.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sapegin
pushed a commit
that referenced
this pull request
Oct 8, 2018
This was referenced Apr 7, 2021
Open
Open
This was referenced Sep 12, 2021
Open
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as: #1125
Document gets a horizontal scrollbar on a small viewport because of the props-table which gets too wide.