Fix basic example to make install instructions work #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
changed the title
|
Thanks! We use Acorn 6 directly, and it's also a dependency of Buble that should be fixed to the version that users version 6 as well. Other than that Acorn is used by ESLint and probably something else. |
This was referenced Dec 7, 2020
Open
This was referenced Oct 1, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1232 (instead of just closing and locking it). The main thing that fixes the install is deleting package-lock.json and regenerating it. I tried investigating further why that helped and it seems to becease two different acorn versions are installed and the main one should be 6.0.4, not 5.7.1. Otherwise you get this weird import error.